-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumps in garden : ign-cmake3, ign-util2, ign-plugin2 #74
Conversation
Signed-off-by: Brandon Ong <[email protected]>
Run with command: https://github.com/ignitionrobotics/ign-plugin/pull/74/files#diff-b171701a8039aa411e8f6a1710925af464824660092863f0ff3f4e426f89402bL259 might be an edge case, perhaps an instance of greedy matching? It doesn't look like Also, I'm not sure ign-common5 and ign-math7 was bumped... Will it cause downstream issues? |
Ouch yes, that doesn't need to change
Oh that was actually the script being kinda smart! It's unusual that a library has a reference to libraries that aren't direct dependencies, which is the case of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one extra comment besides the other issue that you already caught
Co-authored-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #74 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 17 17
Lines 616 616
=======================================
Hits 614 614
Misses 2 2 Continue to review full report at Codecov.
|
@osrf-jenkins run tests please! |
Windows has a new warning?!
|
It passed on my push, even though nothing changed 😬 But it does still print that |
the windows builds do not fail on cmake warnings because we haven't configured jenkins to check windows jobs with that parser. I think it's fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when CI comes back 🟢 ❗
See gazebo-tooling/release-tools#685